@klahnakoski All of the other
input tags in the project lack the ending /, so I was not adding it to maintain consistency but I tried it for kicks and giggles and it doesn't change anything.
I had hypothesized the same conclusion @arikfr had about the mozilla master branch just being broken, so I had tried reverting all commits I made to the mozilla/redash master branch ever (including a rebase from getredash/redash master the week of June 12) but that had no effect on, for instance, postgres data source connections displaying saved data source info. So then I went forward and tried the branch I have that does a merge from getredash/redash master (https://github.com/mozilla/redash/pull/105) last week and that doesn't show saved data source values either. I also tried a visual comparison of getredash/redash master dynamic-form.html and dynamic-form.js files with my dev branch for this ticket and found no differences that seemed relevant. (There is an improvement to error handling on the save of the form but it doesn't change the behavior in that branch.)
Now, since the values are saving, but not displaying after save, I played around with the
ng-model="target.options[field.name]" in the input tag, since it would seem the Angular data bind to the field is at least a logical place to look. Also, it refers to
target.options instead of
field.property.x like the rest of the Angular references. I tried
field.name and a few other things mostly for kicks but they didn't work.
I also tried a different
__init__() function (commit is synced to my dev branch if you're interested) that mirrors the same function in other query_runners to no effect.
Since the removal of information occurs after the save I also tried commenting out
$scope.dataSourceForm.$setPristine(); on line 132 of dynamic-form.js (even though it should only be changing CSS classes in the form), and that didn't work.
Then, since the doc_url field is working fine and the difference between it and the host_url field are that host_url is required, I commented out the "required" line for the host_url field in the configuration_schema and that didn't help.
Having read dynamic-form.js, @arikfr, it seems most concerned with the type of form field (i.e. checkbox, file, etc.). Could you please point out to me where it's pulling the saved information from the database to assign it to