Cancel button in the queries queue is gone after updating to redash 8.0.0

wvd · June 9, 2021, 3:40pm

Issue Summary

I upgraded my installation of redash from version 6.0.0 to 8.0.0 following the how to upgrade guide (https://redash.io/help/open-source/admin-guide/how-to-upgrade) one by one mayor semantic version at the time and migrating the database as well for each version, almost everything seems to work correctly but under System Status → Queries Queue the cancel button for In progress queries is no longer there, this used to be important in my workflow as some times I needed to prioritize another query in the queue, did I miss something in my upgrade process or is this an expected behavior? if this is expected, is there any plan to bringing this button back in the future?.

Thank you

Technical details:

Redash Version: 8.0.0
Browser/OS: Chrome 90.0.443.212
How did you install Redash: Using Docker, self managed

jesse · June 9, 2021, 10:17pm

I don’t think the cancel button was included in the migration from Angular to React a couple years ago. @levko any idea why?

wvd · June 11, 2021, 1:11pm

I went to see the code and found that the cancel button component is still there in version 8.0.0

github.com

getredash/redash/blob/v8.0.0/client/app/components/cancel-query-button/index.js#L10

    
      
          function cancelQueryButton() {
            return {
              restrict: 'E',
              scope: {
                queryId: '=',
                taskId: '=',
              },
              transclude: true,
              template:
                '<button class="btn btn-default" ng-disabled="inProgress" ng-click="cancelExecution()"><i class="zmdi zmdi-spinner zmdi-hc-spin" ng-if="inProgress"></i> Cancel</button>',
              replace: true,
              controller($scope, $http, currentUser, Events) {
                $scope.inProgress = false;
          
          
      $scope.cancelExecution = () => {
                  $http.delete(`api/jobs/${$scope.taskId}`).success(() => {});
          
          
        let queryId = $scope.queryId;
                  if ($scope.queryId === 'adhoc') {
                    queryId = null;

and it was being used still in version 6.0.0

github.com

getredash/redash/blob/v6.0.0/client/app/pages/admin/tasks/tasks.html#L45

    
      
                <td>{{row.data_source_id}}</td>
                <td>{{row.username}}</td>
                <td>{{row.state}} <span ng-if="row.state === 'failed'" uib-popover="{{row.error}}" popover-trigger="mouseenter" class="zmdi zmdi-help"></span></td>
                <td><a href="queries/{{row.query_id}}">{{row.query_id}}</a></td>
                <td>{{row.query_hash}}</td>
                <td>{{row.run_time | durationHumanize}}</td>
                <td>{{row.created_at | toMilliseconds | dateTime }}</td>
                <td>{{row.started_at | toMilliseconds | dateTime }}</td>
                <td>{{row.updated_at | toMilliseconds | dateTime }}</td>
                <td ng-if="selectedTab === 'in_progress'">
                  <cancel-query-button query-id="row.query_id" task-id="row.task_id"></cancel-query-button>
                </td>
              </tr>
              </tbody>
            </table>
            <paginator paginator="$ctrl.tasksPaginator"></paginator>
          
          
  <div class="p-15">
              <label><input type="checkbox" ng-model="autoUpdate"> Auto Update</label>
            </div>
          </div>

but on version 7.0.0 this view section was replaced with an admin celery status component that doesn’t have it

github.com

getredash/redash/blob/v7.0.0/client/app/components/admin/CeleryStatus.jsx

import React from 'react';
import PropTypes from 'prop-types';
import { $http } from '@/services/ng';
import Table from 'antd/lib/table';
import Col from 'antd/lib/col';
import Row from 'antd/lib/row';
import Card from 'antd/lib/card';
import Spin from 'antd/lib/spin';
import Badge from 'antd/lib/badge';
import Tabs from 'antd/lib/tabs';
import Alert from 'antd/lib/alert';
import moment from 'moment';
import values from 'lodash/values';
import { Columns } from '@/components/items-list/components/ItemsTable';

function parseTasks(tasks) {
  const queues = {};
  const queries = [];
  const otherTasks = [];

This file has been truncated. show original

so I guess this answers my question

jesse · June 14, 2021, 6:36pm

That looks right to me. You can still cancel jobs with the API. The button just isn’t there. Maybe we should add it back?

wvd · June 15, 2021, 3:34pm

That would be amazing as there are features from the new version that I would like to try, I hope this is possible in the future, thank you so much for the support

Best

▼Categories

▼Tags

Cancel button in the queries queue is gone after updating to redash 8.0.0

Issue Summary

Technical details: