Maybe logic duplication in GET queries

SawlStone · September 27, 2021, 11:07am

I think there is some logic duplication:

getredash/redash/blob/master/redash/handlers/queries.py#L151

    
      
          :qparam number page_size: Number of queries to return per page
          :qparam number page: Page number to retrieve
          :qparam number order: Name of column to order by
          :qparam number q: Full text search term
          
          
Responds with an array of :ref:`query <query-response-label>` objects.
          """
          # See if we want to do full-text search or just regular queries
          search_term = request.args.get("q", "")
          
          
queries = self.get_queries(search_term)
          
          
results = filter_by_tags(queries, models.Query.tags)
          
          
# order results according to passed order parameter,
          # special-casing search queries where the database
          # provides an order by search rank
          ordered_results = order_results(results, fallback=not bool(search_term))
          
          
page = request.args.get("page", 1, type=int)
          page_size = request.args.get("page_size", 25, type=int)

Method get_queries returns filter_by_tags results and on the next line returned data processed by filter_by_tags function too

▼Categories

▼Tags

Maybe logic duplication in GET queries