Needless models.db.session.commit in WidgetListResource:post

SawlStone · December 28, 2020, 9:11am

Is it necessary to have second models.db.session.commit() here?

getredash/redash/blob/master/redash/handlers/widgets.py#L53


            require_access(visualization.query_rel, self.current_user, view_only)
        else:
            visualization = None
        widget_properties["visualization"] = visualization
        widget = models.Widget(**widget_properties)
        models.db.session.add(widget)
        models.db.session.commit()
        models.db.session.commit()
        return serialize_widget(widget)
class WidgetResource(BaseResource):
    @require_permission("edit_dashboard")
    def post(self, widget_id):
        """
        Updates a widget in a dashboard.
        This method currently handles Text Box widgets only.

guyu · December 28, 2020, 10:35am

Just once commit() is ok

SawlStone · December 28, 2020, 12:43pm

Yes, I know, it was the rhetorical question. Maybe guys will want to update this 4 years old part of code

guyu · December 29, 2020, 7:19am

ok, i hadn’t notice it.

▼Categories

▼Tags

Needless models.db.session.commit in WidgetListResource:post