I know you all love the lovely CodeClimate errors, like
Your method has 7 lines (exceeds 6 allowed) I was also annoyed by the fact that whenever it finds lint issues, you can either ignore them or have to push another commit for really inconsequential issues like “File not ending with a blank line”.
This is the pull request that adds support for it:
I also did a dummy commit with a Flake8 violation, to trigger its fix:
- Commit with issue: https://github.com/getredash/redash/pull/3302/commits/531aa73964de7d57ed11604afa0418995ff8d6cc
- Stickler’s fix commit: https://github.com/getredash/redash/pull/3302/commits/61b1314069438e748d113999fc3e4b9ca3c541b2
It seems to do its job, but what bothered me here was how silent it was – there was no visible feedback on what actually failed aside from the follow up commit.
For the above reason, I decided to wait with merging it into our repository and wait for more comments… So what do you think?