1

Working on Alerts feature breakdown Aug '19 - #5 by ranbena I attempted to eliminate the Alert Name field as it is redundant if swapped for the “edit-in-place” component, already implemented in Dashboard and Query pages.

@arikfr said:

While it’s consistent with the other pages, it doesn’t look clickable much :thinking: (we might have the same problem on dashboards/queries, but we are just used to it). Not sure this is a pattern we need to keep. Or at least we need to have some visual cue that this is the case when in edit mode.

So, let’s discuss it. Here’s how the feature works:

com-video-to-gif
com-video-to-gif800×73 252 KB

2

Personally, I like edit-in-place cause it doesn’t take up space. It does only when in edit mode.
Google Docs does it the same way and probably for the same reason.

The disadvantage is that you don’t know the title is editable till you hover it and get the yellow indication.

To address the clarity problem, I thought of maybe adding a small edit (pencil) button but I don’t like how it looks and for Dashboards it can get too crowded.

33

Wdyt?

3

One solution is to make all editable pages have view/edit modes.
In view mode - title is non-editable.
In edit mode - title has clear editable indication (textfield around it, or yellow bg, etc.).

It actually already works like that for Dashboards (title non-editable till dashboard is in edit mode).
For Alert we can do the same - we’re planning a view only mode anyway.
That would mean we need a view only mode for Query page.

4

To address the clarity problem, I thought of maybe adding a small edit (pencil) button but I don’t like how it looks and for Dashboards it can get too crowded.

33

Maybe this button can escape icon-mania, if it takes the :star:’s place.
Then, it would have a consistent location amongst all editable title pages.

18
18772×90 10.2 KB

So, then where would the :star:go?

  1. As a right side button

    07

    53

  2. As a menu item with a dedicated tag.

    45

    54
    54732×102 10 KB

5

We have one: it’s the results only view.

I don’t think we need it when editing. So the pencil can take its place, otherwise I wouldn’t move the Favorite control anywhere.

We can also remove the publish status and user’s avatar in edit mode to better signal something happened. I would also consider putting a border around the title to signal it’s editable.

6

Some additional options:

  1. Make the title an input box when going into edit mode and drop all the attempts to signal it’s editable.
  2. Put an “Edit” button next to the title.
7

@arikfr we’re talking about the same thing.
Two options:

  1. Edit/view modes in which it’s very clear that it’s editable.
  2. What I suggested in Comment #4.

We have one: it’s the results only view.

That’s “Edit Source” mode - not the same and would need tweaking if we go for option 1.

8

I think that we should go with very clear indication that it’s editable in edit view. How exactly, I will leave to you.

We can also keep Query page as is. It’s not optimal, but it considering it’s complexity it shouldn’t stop us from improving the other pages.

1 Like